5 Commits

Include renames

Author	SHA1	Message	Date
Thom Lamb	e3153e58c4	fix(security): Resolve SonarQube security hotspots ... Introduce a default regex match timeout across the library to prevent potential ReDoS attacks (SonarQube rule S6444). Implement `[OnDeserialized]` methods to re-establish object invariants and validate state after deserialization, addressing SonarQube rule S5766.	2026-05-20 17:19:17 -05:00
Thom LambandClaude Opus 4.7	5cb32d2311	refactor(query): extract shared Strata.SqlTools.Query model project ... Moves the byte-identical 19-file ExpressionFactory/Query tree (duplicated across Snowflake and SqlServer) into the new Strata.SqlTools.Query project under the flat namespace Strata.SqlTools.Query. Both dialect projects now reference the shared project; the Snowflake copies are deleted. Also folds in the IDE0028 fix on CalculationFilterGroup.GetValidFilters (collection expression []), which resolves both new-code IDE0028 smells in one place now that there is a single copy. Eliminates the 63 new duplicate lines flagged on the PR and removes the largest contributor to the project's 11.1% duplication density. No behavioral change: the moved types are identical to the originals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 12:04:01 -05:00
Thom LambandClaude Opus 4.7	e01cfae359	perf+docs: fix IsValid allocation regression and document FilterGroup asymmetry ... Code review follow-up on 6f85358: - CalculationFilterGroup.IsValid() previously called GetValidFilters().Any(), which materialized a full filtered List<CalculationFilter> just to check existence. Reimplement directly as Filters.Any(x => x.IsValid()) so IsValid() recovers its pre-refactor O(1) early-exit behavior without allocations. GetValidFilters() remains for callers that need the full materialized list. - QueryConfigExtensions.GetAllColumnIds line 16 uses FilterGroup (not CalculationFilterGroup), which pre-filters in its JsonConstructor and has no GetValidFilters() method. Add a comment to document the intentional asymmetry between line 14 and line 16. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 17:01:08 -05:00
Thom LambandClaude Opus 4.7	6f85358f63	refactor: address S2365 collection-copying property getters ... Resolves SonarQube S2365 x3. CalculationFilterGroup (Snowflake + SqlServer): the `Filters` getter ran .Where(...).ToList() on every access. Convert to a plain auto-property holding the raw collection plus a `GetValidFilters()` method that does the filtering. Update internal IsValid() and the two QueryConfigExtensions callers to use the new method. HierarchicalData.AllChildData: part of the IHierarchicalData interface and JSON-serialized; the transformation IS the property's contract. Suppress S2365 with justification rather than refactor -- same pattern as S3875. Behavior change: CalculationFilterGroup JSON output now serializes the raw filter collection rather than the pre-filtered one. Round-trip is preserved; callers needing the filtered view must call GetValidFilters(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 16:55:13 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00