7 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	5202d93e8e	chore(sonar)!: mark public Markdown generator methods static (CA1822) ... Three public methods on the SqlServer-namespaced Markdown generators no longer touch instance state and now carry the `static` keyword: - `Markdown.SqlServer.QueryBreakdownGenerator.GenerateMermaidDiagram(QueryBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(ISqlBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateEntityRelationshipDiagram(IEnumerable<string>, string?)` Plus one private bonus the analyzer caught on the same pass: - `LinqExpressionVisitor.ExtractSelectExpression` → static (non-breaking). Internal callers in the Snowflake/LinqToSql/PostgreSql wrapper classes and in the test fixtures are updated to the type-name form (`SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`). The wrappers retain their `_baseGenerator` field for now even though it is no longer used — that S4487 / unused-field cleanup is its own commit. BREAKING CHANGE: External NuGet consumers calling `generatorInstance.GenerateMermaidDiagram(...)`, `generatorInstance.GenerateSequenceDiagram(...)`, or `generatorInstance.GenerateEntityRelationshipDiagram(...)` on the SqlServer-namespaced generators must switch to type-name form, e.g. `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`. Calls through the Snowflake / LinqToSql / PostgreSql wrapper classes are unaffected at the call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:22:27 -05:00
Thom LambandClaude Opus 4.7	3c602a4625	chore(sonar): mark private helpers static (CA1822) ... Two private methods that don't touch instance state get the `static` keyword: - `LinqExpressionVisitor.ExtractMemberName` - `Markdown.Expressions.ExpressionGenerator.GenerateMermaidDiagram(Expression)` Both have only intra-class callers, so this is a non-breaking change — the call sites continue to work unchanged under C# method-resolution. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:19:26 -05:00
Thom LambandClaude Opus 4.7	84b06557e5	chore(sonar)!: mark instance-data-free members static (CA1822) ... Applied via `dotnet format analyzers --diagnostics CA1822 --severity info`. 12 files touched. The fixer also updated internal callers in tests to use the type-name form (e.g. `gen.Method(x)` -> `Generator.Method(x)`); build and full test suite remain green. BREAKING CHANGE: two public methods become static and therefore can no longer be invoked through an instance reference by external consumers: - Strata.SqlTools.Markdown.LinqToSql.QueryBreakdownGenerator.GenerateMethodChainDiagram - Strata.SqlTools.Markdown.LinqToSql.SqlStatementGenerator.GenerateLinqPipelineDiagram Both are stateless utility methods on Generator classes — the static form is the correct shape; the only callers in this repo already used the type-name form. External code should change `gen.GenerateMethodChainDiagram(...)` to `QueryBreakdownGenerator.GenerateMethodChainDiagram(...)`. All other CA1822 hits in this commit are on private/protected members (no public-surface impact). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:41:46 -05:00
Thom LambandClaude Opus 4.7	2c2a8b1193	chore(sonar): bulk-fix mechanical CA/IDE analyzer warnings ... Applied via `dotnet format analyzers --diagnostics IDE0028 CA1825 CA1834 CA1845 CA1847 CA1860 CA1866 CA1853 CA1830 CA1846 CA1806 CA1869 CA2249 --severity info`. 19 files touched, all mechanical syntactic rewrites: - CA1847: string.Contains("x") -> string.Contains('x') - CA2249: s.IndexOf(c) == -1 -> !s.Contains(c) - CA1830: sb.Append(sb.ToString()) -> sb.Append(sb) - CA1834: StringBuilder.Append("x") -> Append('x') - CA1825, CA1860, CA1866, CA1853, IDE0028, CA1845: corresponding fixers Three rules in the batch had no batch fixer available (CA1846 ×4, CA1806 ×1, CA1869 ×1) and stay open for separate manual handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:38:54 -05:00
Thom Lamb	012e693fe1	chore: refactor for sonarqube issues	2026-05-22 17:13:31 -05:00
Thom Lamb	84b1f83c0f	chore: working on cleaning up more dup lines	2026-05-21 16:50:13 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00