5 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	6175dcde96	chore(sonar)!: cascade CA1822 through Markdown dialect wrappers ... Commit 5202d93 made the SqlServer-namespaced Markdown generator methods static, which left the LinqToSql / PostgreSql / Snowflake wrapper classes' instance methods delegating to nothing but a static call. SonarQube re-flagged those 10 wrapper methods as CA1822 on the next scan. This sweep: - Makes all 10 wrapper instance methods `static` (`dotnet format` driven). - Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram` static preemptively — it composes two static helpers and would otherwise be the next-iteration cascade flag. - Removes the now-dead `_baseGenerator` field and its initializing constructor from all six dialect wrappers (LinqToSql / PostgreSql / Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The classes keep their implicit parameterless constructor so `new Snowflake.QueryBreakdownGenerator()` still compiles. - Updates the one test call site (`GenerateCombinedDiagram`) the fixer didn't catch to use type-name form. BREAKING CHANGE: External NuGet consumers calling `instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`, `Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`. The class types and parameterless constructors remain — only the call syntax for these methods changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:38:58 -05:00
Thom LambandClaude Opus 4.7	5202d93e8e	chore(sonar)!: mark public Markdown generator methods static (CA1822) ... Three public methods on the SqlServer-namespaced Markdown generators no longer touch instance state and now carry the `static` keyword: - `Markdown.SqlServer.QueryBreakdownGenerator.GenerateMermaidDiagram(QueryBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(ISqlBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateEntityRelationshipDiagram(IEnumerable<string>, string?)` Plus one private bonus the analyzer caught on the same pass: - `LinqExpressionVisitor.ExtractSelectExpression` → static (non-breaking). Internal callers in the Snowflake/LinqToSql/PostgreSql wrapper classes and in the test fixtures are updated to the type-name form (`SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`). The wrappers retain their `_baseGenerator` field for now even though it is no longer used — that S4487 / unused-field cleanup is its own commit. BREAKING CHANGE: External NuGet consumers calling `generatorInstance.GenerateMermaidDiagram(...)`, `generatorInstance.GenerateSequenceDiagram(...)`, or `generatorInstance.GenerateEntityRelationshipDiagram(...)` on the SqlServer-namespaced generators must switch to type-name form, e.g. `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`. Calls through the Snowflake / LinqToSql / PostgreSql wrapper classes are unaffected at the call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:22:27 -05:00
Thom LambandClaude Opus 4.7	84b06557e5	chore(sonar)!: mark instance-data-free members static (CA1822) ... Applied via `dotnet format analyzers --diagnostics CA1822 --severity info`. 12 files touched. The fixer also updated internal callers in tests to use the type-name form (e.g. `gen.Method(x)` -> `Generator.Method(x)`); build and full test suite remain green. BREAKING CHANGE: two public methods become static and therefore can no longer be invoked through an instance reference by external consumers: - Strata.SqlTools.Markdown.LinqToSql.QueryBreakdownGenerator.GenerateMethodChainDiagram - Strata.SqlTools.Markdown.LinqToSql.SqlStatementGenerator.GenerateLinqPipelineDiagram Both are stateless utility methods on Generator classes — the static form is the correct shape; the only callers in this repo already used the type-name form. External code should change `gen.GenerateMethodChainDiagram(...)` to `QueryBreakdownGenerator.GenerateMethodChainDiagram(...)`. All other CA1822 hits in this commit are on private/protected members (no public-surface impact). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:41:46 -05:00
Thom Lamb	012e693fe1	chore: refactor for sonarqube issues	2026-05-22 17:13:31 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00