4 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	423108a7dc	chore(sonar)!: mark Markdown generator classes as 'public static class' (S1118) ... After the CA1822 cascade in #15 left every method on the eight Markdown generator classes static, the classes themselves were instantiable shells that consumers couldn't usefully `new`. This commit flips the `class` modifier to `static class` on all eight: - `Markdown.SqlServer.QueryBreakdownGenerator` - `Markdown.SqlServer.SqlStatementGenerator` - `Markdown.LinqToSql.QueryBreakdownGenerator` - `Markdown.LinqToSql.SqlStatementGenerator` - `Markdown.PostgreSql.QueryBreakdownGenerator` - `Markdown.PostgreSql.SqlStatementGenerator` - `Markdown.Snowflake.QueryBreakdownGenerator` - `Markdown.Snowflake.SqlStatementGenerator` Test fixtures drop the now-meaningless `_generator = new …()` field and `[SetUp]` (kept the existing Setup body where unrelated state was also initialized — `QueryMarkdownGenerationTests` and `LinqToSql.QueryBreakdownGeneratorTests`). BREAKING CHANGE: External NuGet consumers can no longer write `new Markdown.Snowflake.SqlStatementGenerator()` (or any of the other seven classes above) — the type is now a static container and may only be referenced by name, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(…)`. The call syntax for the static methods is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 15:08:48 -05:00
Thom LambandClaude Opus 4.7	6175dcde96	chore(sonar)!: cascade CA1822 through Markdown dialect wrappers ... Commit 5202d93 made the SqlServer-namespaced Markdown generator methods static, which left the LinqToSql / PostgreSql / Snowflake wrapper classes' instance methods delegating to nothing but a static call. SonarQube re-flagged those 10 wrapper methods as CA1822 on the next scan. This sweep: - Makes all 10 wrapper instance methods `static` (`dotnet format` driven). - Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram` static preemptively — it composes two static helpers and would otherwise be the next-iteration cascade flag. - Removes the now-dead `_baseGenerator` field and its initializing constructor from all six dialect wrappers (LinqToSql / PostgreSql / Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The classes keep their implicit parameterless constructor so `new Snowflake.QueryBreakdownGenerator()` still compiles. - Updates the one test call site (`GenerateCombinedDiagram`) the fixer didn't catch to use type-name form. BREAKING CHANGE: External NuGet consumers calling `instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`, `Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`. The class types and parameterless constructors remain — only the call syntax for these methods changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:38:58 -05:00
Thom LambandClaude Opus 4.7	84b06557e5	chore(sonar)!: mark instance-data-free members static (CA1822) ... Applied via `dotnet format analyzers --diagnostics CA1822 --severity info`. 12 files touched. The fixer also updated internal callers in tests to use the type-name form (e.g. `gen.Method(x)` -> `Generator.Method(x)`); build and full test suite remain green. BREAKING CHANGE: two public methods become static and therefore can no longer be invoked through an instance reference by external consumers: - Strata.SqlTools.Markdown.LinqToSql.QueryBreakdownGenerator.GenerateMethodChainDiagram - Strata.SqlTools.Markdown.LinqToSql.SqlStatementGenerator.GenerateLinqPipelineDiagram Both are stateless utility methods on Generator classes — the static form is the correct shape; the only callers in this repo already used the type-name form. External code should change `gen.GenerateMethodChainDiagram(...)` to `QueryBreakdownGenerator.GenerateMethodChainDiagram(...)`. All other CA1822 hits in this commit are on private/protected members (no public-surface impact). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:41:46 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00