7 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	6af239035b	chore(sonar): use concrete return types where binary-safe (CA1859) ... CA1859 has no `dotnet format` batch fixer, so applied manually after verifying each site is private/internal/test (no public-surface impact): - Markdown.TryParseLogicalOperation: Expression? -> BoolExpr? (private) - Markdown.TryParseComparison: Expression? -> Comparison? (private) - RuleSet.GetAllSingleRules(IGroup): IEnumerable<SingleRule> -> List<SingleRule> (private overload) - SqlExpressionClause.SplitOnComma: IEnumerable<string> -> List<string> (private) - QueryBreakdownRepositoryTests._repository: IQueryBreakdownRepository -> QueryBreakdownRepository (test private field) - UnitTest1.StartsWith(...,string): Expression -> MethodCallExpression (test private helper) The public `RuleSet.GetAllSingleRules()` overload still returns IEnumerable<SingleRule> — only the private recursive helper was tightened. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:49:20 -05:00
Thom LambandClaude Opus 4.7	c06ab2ea29	chore(sonar): remove pass-through override that just calls base (S1185) ... Rules/Rule/Groups/With.GetExpressions only called base.GetExpressions(). The comment 'do some ordering here??' indicates the override is a TODO stub. Drop the override and preserve the intent as an inline TODO on the class. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 09:27:53 -05:00
Thom Lamb	012e693fe1	chore: refactor for sonarqube issues	2026-05-22 17:13:31 -05:00
Thom Lamb	e3153e58c4	fix(security): Resolve SonarQube security hotspots ... Introduce a default regex match timeout across the library to prevent potential ReDoS attacks (SonarQube rule S6444). Implement `[OnDeserialized]` methods to re-establish object invariants and validate state after deserialization, addressing SonarQube rule S5766.	2026-05-20 17:19:17 -05:00
Thom LambandClaude Opus 4.7	e2bfe3906a	fix(rules): suppress S3875 on intentional DSL operator== ... Resolves SonarQube S3875 (BLOCKER) in Expression.Operators.cs. The operator== returns a Comparison expression (DSL semantics), not a bool. The existing CS0660/CS0661 pragma already documents this design; the new SuppressMessage attribute makes the Sonar analyzer agree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 15:48:29 -05:00
Thom LambandClaude Opus 4.7	986fdfc503	fix(rules): rename IVisitor.VisitNotEquals parameter to match impls ... Resolves SonarQube S927 x2 in ExpressionVisitor.cs. The interface parameter was named ``Equal`` on a ``VisitNotEquals`` method, which is semantically wrong and forced implementations to mismatch. Implementations already used ``notEqual``; rename the interface to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 15:19:10 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00