6 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	0f8d505616	chore(sonar): apply collection-expression syntax across all sites (IDE0028) ... Manual sweep of all 42 IDE0028 sites flagged by SonarQube — `dotnet format analyzers --diagnostics IDE0028` declined to fix these (no .editorconfig opt-in for `dotnet_style_prefer_collection_expression`), so applied by hand. The repo already targets `<LangVersion>latest</LangVersion>` on net8.0, so C# 12 collection expressions are available. Pattern: `new List<T>()` / `new Dictionary<K,V>()` / `new ArrayList()` / `new()` -> `[]` for empty; `new List<T> { ... }` -> `[...]` for literal. 24 files touched in src/{EFCore, LinqToSql, Query, Snowflake, SqlBreakdown, SqlServer}; tests untouched (no IDE0028 sites in test code). Build clean (35 warnings unchanged from baseline, 0 errors). All tests remain green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 17:01:30 -05:00
Thom LambandClaude Opus 4.7	8b7fc1a327	chore(sonar): use ArgumentNullException.ThrowIfNull (CA1510) ... Applied via `dotnet format analyzers --diagnostics CA1510 --severity info`. Replaces `if (x == null) throw new ArgumentNullException(nameof(x));` blocks with the one-line `ArgumentNullException.ThrowIfNull(x);` — same behavior, same parameter name, much less noise. 6 files touched across SqlBreakdown, SqlServer, LinqToSql. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:39:49 -05:00
Thom LambandClaude Opus 4.7	2c2a8b1193	chore(sonar): bulk-fix mechanical CA/IDE analyzer warnings ... Applied via `dotnet format analyzers --diagnostics IDE0028 CA1825 CA1834 CA1845 CA1847 CA1860 CA1866 CA1853 CA1830 CA1846 CA1806 CA1869 CA2249 --severity info`. 19 files touched, all mechanical syntactic rewrites: - CA1847: string.Contains("x") -> string.Contains('x') - CA2249: s.IndexOf(c) == -1 -> !s.Contains(c) - CA1830: sb.Append(sb.ToString()) -> sb.Append(sb) - CA1834: StringBuilder.Append("x") -> Append('x') - CA1825, CA1860, CA1866, CA1853, IDE0028, CA1845: corresponding fixers Three rules in the batch had no batch fixer available (CA1846 ×4, CA1806 ×1, CA1869 ×1) and stay open for separate manual handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:38:54 -05:00
Thom LambandClaude Opus 4.7	1124e91141	chore(sonar): remove three unused local variables (S1481) ... - LinqQueryBreakdown.cs:211 - drop unused `expr` pattern binding (type test remains) - LinqQueryBreakdown.cs:279 - drop unused `firstEntity` (empty check already above) - LinqExpressionVisitor.cs:315 - drop unused `param` pattern binding Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 09:25:34 -05:00
Thom Lamb	2d9148547f	fix(serialization): Remove legacy BinaryFormatter support ... The `[Serializable]` attribute and corresponding `[OnDeserialized]` methods have been removed from various breakdown classes. This eliminates reliance on `BinaryFormatter`, which is a deprecated and insecure serialization mechanism in modern .NET. This change also resolves SonarQube rule S5766 warnings by removing the context in which they apply, leading to cleaner and more secure code.	2026-05-20 17:44:21 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00