4 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	67512d23e1	chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045) ... Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer groups consecutive independent `Assert.That(...)` calls into `Assert.Multiple(() => { ... })`, so a failing assertion no longer short-circuits the block — every failure inside the group is reported, which gives much better diagnostics on multi-property tests. Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass / Assert.DoesNotThrow got pulled inside a Multiple block (those need to short-circuit). All 1180 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:59:47 -05:00
Thom LambandClaude Opus 4.7	505ada5017	chore(sonar): adopt Has.Count, Is.Empty, Does.Contain, char overloads in tests (NUnit2046, NUnit2011, CA1866) ... - NUnit2046: `Assert.That(x.Count, Is.EqualTo(n))` → `Assert.That(x, Has.Count.EqualTo(n))` (or `Is.Empty` when n==0) - NUnit2011: `Assert.That(s.Contains(x))` → `Assert.That(s, Does.Contain(x))` for richer failure messages - CA1866: `.StartsWith("$"|"@"|":")` → `.StartsWith('$'|'@'|':')` char overload Driven by `dotnet format analyzers --diagnostics NUnit2046 NUnit2011 CA1866` for the cases the Roslyn fixer handles, plus a regex sweep for the remaining `Count == n` (n>0) cases which the fixer doesn't address. CA1866 had no associated code fix and was edited by hand (3 sites in 2 files). All tests green (1180 passing). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:58:00 -05:00
Thom LambandClaude Opus 4.7	f5d539b906	chore(sonar): hoist constant array literals to static readonly fields (CA1861) ... Applied via `dotnet format analyzers --diagnostics CA1861 --severity info`, plus manual cleanup: - Renamed two cryptic fixer-generated field names: - QueryBreakdownCollection.stringArray -> SnowflakeFunctionNames (and inlined the now-redundant local alias) - ExpressionObjectTests.arg2 -> NotInValues - Deduped three identical `separator = ['\r','\n']` fields the fixer emitted in the same test class (kept the first declaration; the other two test methods now reuse it). 8 files touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:45:16 -05:00
Thom Lamb	8b0368e810	test: fix SqlBreakdown tests project	2026-05-15 13:39:14 -05:00