chore(sonar): clear residual test-file smells (NUnit2046, NUnit2045, CS8604)
SonarQube Analysis / sonarqube (pull_request) Successful in 3m41s

- **NUnit2046 (15)**: extend the prior regex sweep to also catch the
  `Is.GreaterThan(n)` / `Is.GreaterThanOrEqualTo(n)` variants on
  `.Count` and `.Length` — the previous pass only handled `Is.EqualTo`.
  Affects PG/Snowflake `QueryBreakdownTests`, PG `StatementReaderTests`,
  `LinqToSql` `QueryComparatorTests` / `QueryValidatorTests`,
  `Markdown.Tests` `ExpressionGeneratorTests` /
  `QueryBreakdownGeneratorTests`, and `JsonTokenReaderTests`.

- **CS8604 (8)**: `merged[someKey]` access inside `Assert.Multiple(() =>
  { ... })` lambdas where `someKey` is `string?` from `FirstOrDefault`.
  The preceding `Assert.That(someKey, Is.Not.Null)` does not propagate
  null-narrowing into the lambda scope, so add `!` to the dictionary
  index. (Tests fail loud with a meaningful message if the key really
  is null, so this is safe.)

- **NUnit2045 (1)**: wrap a four-assert block in
  `JsonTokenReaderTests.cs:65-68` in `Assert.Multiple`. Mirrors the
  surrounding two `Assert.Multiple` groups in that method.

All 1180 tests stay green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thom Lamb
2026-05-27 15:29:20 -05:00
co-authored by Claude Opus 4.7
parent 1345a9219e
commit f55d8130e6
12 changed files with 23 additions and 23 deletions
@@ -383,7 +383,7 @@ public class QueryBreakdownTests
// Assert
// Snowflake stores parameters in both @ and : formats, so count is doubled
Assert.That(merged.Count, Is.GreaterThanOrEqualTo(2));
Assert.That(merged, Has.Count.GreaterThanOrEqualTo(2));
Assert.Multiple(() =>
{
Assert.That(merged.ContainsKey("@UserId") || merged.ContainsKey(":UserId"), Is.True);
@@ -1041,7 +1041,7 @@ public class QueryBreakdownTests
var queryBreakdown = QueryBreakdown.Parse(sql, false);
// Assert
Assert.That(queryBreakdown.Parameters.Count, Is.GreaterThanOrEqualTo(5));
Assert.That(queryBreakdown.Parameters, Has.Count.GreaterThanOrEqualTo(5));
Assert.That(queryBreakdown.Parameters, Does.ContainKey(":userId"));
Assert.That(queryBreakdown.Parameters, Does.ContainKey(":startDate"));
Assert.That(queryBreakdown.Parameters, Does.ContainKey(":endDate"));
@@ -1156,7 +1156,7 @@ public class QueryBreakdownTests
// Assert
Assert.That(sql, Does.Contain("CTE_0 AS ("));
Assert.That(sql, Does.Contain("CTE_14 AS ("));
Assert.That(sql.Length, Is.GreaterThan(1000));
Assert.That(sql, Has.Length.GreaterThan(1000));
}
#endregion
@@ -1323,7 +1323,7 @@ public class QueryBreakdownTests
Assert.Multiple(() =>
{
Assert.That(sql, Does.Contain("LIMIT 100"));
Assert.That(mainQueryBreakdown.Parameters.Count, Is.GreaterThanOrEqualTo(2));
Assert.That(mainQueryBreakdown.Parameters, Has.Count.GreaterThanOrEqualTo(2));
});
}
@@ -2069,7 +2069,7 @@ public class QueryBreakdownTests
query.AddWhereClause("CREATED_DATE > :StartDate", "and", false);
// Assert
Assert.That(query.Parameters.Count, Is.GreaterThanOrEqualTo(3));
Assert.That(query.Parameters, Has.Count.GreaterThanOrEqualTo(3));
Assert.That(query.Parameters, Does.ContainKey(":UserId"));
Assert.That(query.Parameters, Does.ContainKey(":Status"));
Assert.That(query.Parameters, Does.ContainKey(":StartDate"));
@@ -185,7 +185,7 @@ public class RecursiveCTETests
Assert.Multiple(() =>
{
Assert.That(statusKey, Is.Not.Null);
Assert.That(merged[statusKey], Is.EqualTo("active"), "Main query parameter should take precedence");
Assert.That(merged[statusKey!], Is.EqualTo("active"), "Main query parameter should take precedence");
});
}