chore(sonar): clear residual test-file smells (NUnit2046, NUnit2045, CS8604)
SonarQube Analysis / sonarqube (pull_request) Successful in 3m41s

- **NUnit2046 (15)**: extend the prior regex sweep to also catch the
  `Is.GreaterThan(n)` / `Is.GreaterThanOrEqualTo(n)` variants on
  `.Count` and `.Length` — the previous pass only handled `Is.EqualTo`.
  Affects PG/Snowflake `QueryBreakdownTests`, PG `StatementReaderTests`,
  `LinqToSql` `QueryComparatorTests` / `QueryValidatorTests`,
  `Markdown.Tests` `ExpressionGeneratorTests` /
  `QueryBreakdownGeneratorTests`, and `JsonTokenReaderTests`.

- **CS8604 (8)**: `merged[someKey]` access inside `Assert.Multiple(() =>
  { ... })` lambdas where `someKey` is `string?` from `FirstOrDefault`.
  The preceding `Assert.That(someKey, Is.Not.Null)` does not propagate
  null-narrowing into the lambda scope, so add `!` to the dictionary
  index. (Tests fail loud with a meaningful message if the key really
  is null, so this is safe.)

- **NUnit2045 (1)**: wrap a four-assert block in
  `JsonTokenReaderTests.cs:65-68` in `Assert.Multiple`. Mirrors the
  surrounding two `Assert.Multiple` groups in that method.

All 1180 tests stay green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thom Lamb
2026-05-27 15:29:20 -05:00
co-authored by Claude Opus 4.7
parent 1345a9219e
commit f55d8130e6
12 changed files with 23 additions and 23 deletions
@@ -162,7 +162,7 @@ public class QueryBreakdownTests
queryBreakdown.AddParameter("param3", new DateTime(2025, 1, 1));
// Assert
Assert.That(queryBreakdown.Parameters.Count, Is.GreaterThanOrEqualTo(3));
Assert.That(queryBreakdown.Parameters, Has.Count.GreaterThanOrEqualTo(3));
Assert.Multiple(() =>
{
Assert.That(queryBreakdown.Parameters.ContainsKey("param1"), Is.True);
@@ -248,7 +248,7 @@ public class QueryBreakdownTests
var queryBreakdown = QueryBreakdown.Parse(sql);
// Assert
Assert.That(queryBreakdown.Parameters.Count, Is.GreaterThanOrEqualTo(0));
Assert.That(queryBreakdown.Parameters, Has.Count.GreaterThanOrEqualTo(0));
}
[Test]
@@ -488,7 +488,7 @@ public class QueryBreakdownTests
// Assert
// PostgreSQL stores parameters with positional and name-based formats
Assert.That(merged.Count, Is.GreaterThanOrEqualTo(2));
Assert.That(merged, Has.Count.GreaterThanOrEqualTo(2));
var keys = merged.Keys.ToList();
Assert.Multiple(() =>
{
@@ -568,7 +568,7 @@ public class QueryBreakdownTests
Assert.Multiple(() =>
{
Assert.That(userIdKey, Is.Not.Null);
Assert.That(merged[userIdKey], Is.EqualTo(123)); // Main query value, not CTE value
Assert.That(merged[userIdKey!], Is.EqualTo(123)); // Main query value, not CTE value
});
}
@@ -623,13 +623,13 @@ public class QueryBreakdownTests
Assert.Multiple(() =>
{
Assert.That(dateKey, Is.Not.Null);
Assert.That(merged[dateKey], Is.TypeOf<DateTime>());
Assert.That(merged[dateKey!], Is.TypeOf<DateTime>());
Assert.That(boolKey, Is.Not.Null);
Assert.That(merged[boolKey], Is.TypeOf<bool>());
Assert.That(merged[boolKey!], Is.TypeOf<bool>());
Assert.That(doubleKey, Is.Not.Null);
Assert.That(merged[doubleKey], Is.TypeOf<double>());
Assert.That(merged[doubleKey!], Is.TypeOf<double>());
});
}
@@ -185,7 +185,7 @@ public class RecursiveCTETests
Assert.Multiple(() =>
{
Assert.That(statusKey, Is.Not.Null);
Assert.That(merged[statusKey], Is.EqualTo("active"), "Main query parameter should take precedence");
Assert.That(merged[statusKey!], Is.EqualTo("active"), "Main query parameter should take precedence");
});
}
@@ -121,7 +121,7 @@ public class StatementReaderTests
// Assert
var identifierTokens = tokens.Where(t => t.Type == TokenType.ColumnIdentifier).ToList();
Assert.That(identifierTokens.Count, Is.GreaterThanOrEqualTo(2));
Assert.That(identifierTokens, Has.Count.GreaterThanOrEqualTo(2));
}
[Test]
@@ -210,7 +210,7 @@ public class StatementReaderTests
// Assert
var stringTokens = tokens.Where(t => t.Type == TokenType.String).ToList();
Assert.That(stringTokens.Count, Is.GreaterThanOrEqualTo(2));
Assert.That(stringTokens, Has.Count.GreaterThanOrEqualTo(2));
}
[Test]