Lambda-Associates/sql-utilities
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rules): suppress S3875 on intentional DSL operator==

Browse Source 
Resolves SonarQube S3875 (BLOCKER) in Expression.Operators.cs.

The operator== returns a Comparison expression (DSL semantics), not a
bool. The existing CS0660/CS0661 pragma already documents this design;
the new SuppressMessage attribute makes the Sonar analyzer agree.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thom Lamb
2026-05-19 15:48:29 -05:00
co-authored by Claude Opus 4.7
parent af2c3e054f
commit e2bfe3906a
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Strata.SqlTools.Rules/Rule/Expression/Expression.Operators.cs
+3
View File
@@ -1,9 +1,12 @@
using System.Diagnostics.CodeAnalysis;
namespace Strata.SqlTools.Rules.Rule.Expression; namespace Strata.SqlTools.Rules.Rule.Expression;
/// <summary> /// <summary>
/// Provides implicit conversion operators and comparison operators for rule expressions. /// Provides implicit conversion operators and comparison operators for rule expressions.
/// </summary> /// </summary>
#pragma warning disable CS0660, CS0661 #pragma warning disable CS0660, CS0661
[SuppressMessage("Major Code Smell", "S3875:\"operator==\" should not be overloaded on reference types", Justification = "Intentional DSL syntax: `expr1 == expr2` constructs a Comparison rule expression, not a bool. The existing CS0660/CS0661 pragma documents the deliberate omission of Equals/GetHashCode for the same reason.")]
public partial class Expression public partial class Expression
#pragma warning restore CS0660, CS0661 #pragma warning restore CS0660, CS0661
{ {