From b6ebb8c7cdf2fcfc159db9e77037f61aaf1f5935 Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Tue, 26 May 2026 09:29:13 -0500 Subject: [PATCH] chore(sonar): demote single-use field to local (S1450) LinqExpressionVisitor._tableName was only assigned and read inside VisitConstant immediately before assigning FromClause. Drop the field entirely and assign FromClause directly from entityType.Name. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../Visitors/LinqExpressionVisitor.cs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs index 9e52b0d..26b6391 100644 --- a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs +++ b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs @@ -13,7 +13,6 @@ public class LinqExpressionVisitor : ExpressionVisitor private readonly StringBuilder _orderByBuilder = new(); private readonly List _methodCalls = new(); private bool _isInWhereClause; - private string? _tableName; /// /// Gets the SELECT clause extracted from the expression. @@ -119,8 +118,7 @@ public class LinqExpressionVisitor : ExpressionVisitor var entityType = node.Type.GetGenericArguments().FirstOrDefault(); if (entityType != null) { - _tableName = entityType.Name; - FromClause = _tableName; + FromClause = entityType.Name; } } }