From 986fdfc5039197a1626949ba801b04837cc4c871 Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Tue, 19 May 2026 15:19:10 -0500 Subject: [PATCH] fix(rules): rename IVisitor.VisitNotEquals parameter to match impls Resolves SonarQube S927 x2 in ExpressionVisitor.cs. The interface parameter was named ``Equal`` on a ``VisitNotEquals`` method, which is semantically wrong and forced implementations to mismatch. Implementations already used ``notEqual``; rename the interface to match. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/Strata.SqlTools.Rules/ExpressionVisitor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Strata.SqlTools.Rules/ExpressionVisitor.cs b/src/Strata.SqlTools.Rules/ExpressionVisitor.cs index 845f38a..2c46eea 100644 --- a/src/Strata.SqlTools.Rules/ExpressionVisitor.cs +++ b/src/Strata.SqlTools.Rules/ExpressionVisitor.cs @@ -14,7 +14,7 @@ public interface IVisitor T VisitLiteral(Literal literalRule); T VisitEquals(Equal Equal); - T VisitNotEquals(NotEqual Equal); + T VisitNotEquals(NotEqual notEqual); T VisitGreaterThan(GreaterThan GreaterThan); T VisitAnd(And And);