chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045)
Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer
groups consecutive independent `Assert.That(...)` calls into
`Assert.Multiple(() => { ... })`, so a failing assertion no longer
short-circuits the block — every failure inside the group is reported,
which gives much better diagnostics on multi-property tests.
Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass
/ Assert.DoesNotThrow got pulled inside a Multiple block (those need to
short-circuit). All 1180 tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
505ada5017
commit
67512d23e1
@@ -27,10 +27,13 @@ public class ReverseConverterTests
|
||||
|
||||
// Assert
|
||||
Assert.That(linqBreakdown, Is.Not.Null);
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("Id"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("Users"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("IsActive = 1"));
|
||||
Assert.That(linqBreakdown.OrderByClause.Clause, Is.EqualTo("Name ASC"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("Id"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("Users"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("IsActive = 1"));
|
||||
Assert.That(linqBreakdown.OrderByClause.Clause, Is.EqualTo("Name ASC"));
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -46,9 +49,12 @@ public class ReverseConverterTests
|
||||
// Act
|
||||
var linqBreakdown = sqlServerBreakdown.ToLinqQueryBreakdown();
|
||||
|
||||
// Assert
|
||||
Assert.That(linqBreakdown.GroupByClause.Clause, Is.EqualTo("Department"));
|
||||
Assert.That(linqBreakdown.HavingClause.Clause, Is.EqualTo("COUNT(*) > 5"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
// Assert
|
||||
Assert.That(linqBreakdown.GroupByClause.Clause, Is.EqualTo("Department"));
|
||||
Assert.That(linqBreakdown.HavingClause.Clause, Is.EqualTo("COUNT(*) > 5"));
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -81,9 +87,12 @@ public class ReverseConverterTests
|
||||
|
||||
// Assert
|
||||
Assert.That(linqBreakdown, Is.Not.Null);
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("user_id"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("users"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("is_active = true"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("user_id"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("users"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("is_active = true"));
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -116,9 +125,12 @@ public class ReverseConverterTests
|
||||
|
||||
// Assert
|
||||
Assert.That(linqBreakdown, Is.Not.Null);
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("USER_ID"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("USERS"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("IS_ACTIVE = TRUE"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(linqBreakdown.SelectClause.Clause, Contains.Substring("USER_ID"));
|
||||
Assert.That(linqBreakdown.FromClause.Clause, Is.EqualTo("USERS"));
|
||||
Assert.That(linqBreakdown.WhereClause.Clause, Is.EqualTo("IS_ACTIVE = TRUE"));
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -252,10 +264,13 @@ public class ReverseConverterTests
|
||||
var result2 = sqlServerBreakdown.ConvertToDialect("POSTGRESQL");
|
||||
var result3 = sqlServerBreakdown.ConvertToDialect("postgresql");
|
||||
|
||||
// Assert
|
||||
Assert.That(result1, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(result2, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(result3, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
// Assert
|
||||
Assert.That(result1, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(result2, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(result3, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -281,10 +296,13 @@ public class ReverseConverterTests
|
||||
var backToLinq2 = toPostgres!.ToLinqQueryBreakdown();
|
||||
var finalToSqlServer = backToLinq2.ConvertToSqlServerBreakdown();
|
||||
|
||||
// Assert - Check that clauses are preserved
|
||||
Assert.That(backToLinq.SelectClause.Clause, Contains.Substring("Id"));
|
||||
Assert.That(backToLinq.FromClause.Clause, Is.EqualTo("Users"));
|
||||
Assert.That(backToLinq.WhereClause.Clause, Is.EqualTo("IsActive = true"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
// Assert - Check that clauses are preserved
|
||||
Assert.That(backToLinq.SelectClause.Clause, Contains.Substring("Id"));
|
||||
Assert.That(backToLinq.FromClause.Clause, Is.EqualTo("Users"));
|
||||
Assert.That(backToLinq.WhereClause.Clause, Is.EqualTo("IsActive = true"));
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -333,11 +351,14 @@ public class ReverseConverterTests
|
||||
var resultSqlServer1 = sqlServerBreakdown.ConvertToDialect("sqlserver");
|
||||
var resultSqlServer2 = sqlServerBreakdown.ConvertToDialect("sql_server");
|
||||
|
||||
// Assert
|
||||
Assert.That(resultPostgres1, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(resultPostgres2, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(resultSqlServer1, Is.SameAs(sqlServerBreakdown));
|
||||
Assert.That(resultSqlServer2, Is.SameAs(sqlServerBreakdown));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
// Assert
|
||||
Assert.That(resultPostgres1, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(resultPostgres2, Is.TypeOf<PostgreSqlBreakdown>());
|
||||
Assert.That(resultSqlServer1, Is.SameAs(sqlServerBreakdown));
|
||||
Assert.That(resultSqlServer2, Is.SameAs(sqlServerBreakdown));
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
Reference in New Issue
Block a user