chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045)
Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer
groups consecutive independent `Assert.That(...)` calls into
`Assert.Multiple(() => { ... })`, so a failing assertion no longer
short-circuits the block — every failure inside the group is reported,
which gives much better diagnostics on multi-property tests.
Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass
/ Assert.DoesNotThrow got pulled inside a Multiple block (those need to
short-circuit). All 1180 tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
505ada5017
commit
67512d23e1
@@ -21,8 +21,11 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
|
||||
// Assert
|
||||
Assert.That(mainQuery.WithClauses, Has.Count.EqualTo(1));
|
||||
Assert.That(mainQuery.WithClauses[0].TableName, Is.EqualTo("active_users"));
|
||||
Assert.That(mainQuery.WithClauses[0].Query, Is.EqualTo(cte));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(mainQuery.WithClauses[0].TableName, Is.EqualTo("active_users"));
|
||||
Assert.That(mainQuery.WithClauses[0].Query, Is.EqualTo(cte));
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -81,8 +84,11 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
|
||||
// Assert
|
||||
var keys = merged.Keys.ToList();
|
||||
Assert.That(keys.Any(k => k.Contains("Status")), "Should include CTE parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("Limit")), "Should include main query parameters");
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(keys.Any(k => k.Contains("Status")), "Should include CTE parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("Limit")), "Should include main query parameters");
|
||||
});
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -101,8 +107,11 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
|
||||
// Assert
|
||||
var valueKey = merged.Keys.FirstOrDefault(k => k.Contains("Value"));
|
||||
Assert.That(valueKey, Is.Not.Null, "Should have a Value parameter");
|
||||
Assert.That(merged[valueKey], Is.EqualTo("main_value"), "Main query parameter should take precedence");
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(valueKey, Is.Not.Null, "Should have a Value parameter");
|
||||
Assert.That(merged[valueKey], Is.EqualTo("main_value"), "Main query parameter should take precedence");
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -152,8 +161,11 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
// Assert
|
||||
Assert.That(query.WithClauses, Has.Count.EqualTo(2));
|
||||
var keys = merged.Keys.ToList();
|
||||
Assert.That(keys.Any(k => k.Contains("MinDate")));
|
||||
Assert.That(keys.Any(k => k.Contains("Status")));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(keys.Any(k => k.Contains("MinDate")));
|
||||
Assert.That(keys.Any(k => k.Contains("Status")));
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -213,9 +225,12 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
|
||||
// Assert
|
||||
var keys = merged.Keys.ToList();
|
||||
Assert.That(keys.Any(k => k.Contains("AnchorLevel")), "Should include anchor parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("MaxLevel")), "Should include recursive parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("QueryLimit")), "Should include main query parameters");
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(keys.Any(k => k.Contains("AnchorLevel")), "Should include anchor parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("MaxLevel")), "Should include recursive parameters");
|
||||
Assert.That(keys.Any(k => k.Contains("QueryLimit")), "Should include main query parameters");
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
@@ -279,10 +294,13 @@ public class LinqQueryBreakdownWithClauseTests
|
||||
|
||||
// Assert
|
||||
var keys = merged.Keys.ToList();
|
||||
Assert.That(keys.Any(k => k.Contains("InnerParam")));
|
||||
Assert.That(keys.Any(k => k.Contains("OuterParam")));
|
||||
Assert.That(keys.Any(k => k.Contains("MainParam")));
|
||||
Assert.That(sql, Contains.Substring("WITH"));
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(keys.Any(k => k.Contains("InnerParam")));
|
||||
Assert.That(keys.Any(k => k.Contains("OuterParam")));
|
||||
Assert.That(keys.Any(k => k.Contains("MainParam")));
|
||||
Assert.That(sql, Contains.Substring("WITH"));
|
||||
});
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
Reference in New Issue
Block a user