Lambda-Associates/sql-utilities
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(sonar)!: cascade CA1822 through Markdown dialect wrappers
SonarQube Analysis / sonarqube (pull_request) Successful in 2m50s
Details

Browse Source 
Commit 5202d93 made the SqlServer-namespaced Markdown generator methods
static, which left the LinqToSql / PostgreSql / Snowflake wrapper
classes' instance methods delegating to nothing but a static call.
SonarQube re-flagged those 10 wrapper methods as CA1822 on the next
scan.

This sweep:

- Makes all 10 wrapper instance methods `static` (`dotnet format` driven).
- Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram`
  static preemptively — it composes two static helpers and would otherwise
  be the next-iteration cascade flag.
- Removes the now-dead `_baseGenerator` field and its initializing
  constructor from all six dialect wrappers (LinqToSql / PostgreSql /
  Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The
  classes keep their implicit parameterless constructor so `new
  Snowflake.QueryBreakdownGenerator()` still compiles.
- Updates the one test call site (`GenerateCombinedDiagram`) the fixer
  didn't catch to use type-name form.

BREAKING CHANGE: External NuGet consumers calling
`instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`,
`Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must
switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`.
The class types and parameterless constructors remain — only the call
syntax for these methods changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thom Lamb
2026-05-27 14:38:58 -05:00
co-authored by Claude Opus 4.7
parent 3ba7a7e9f3
commit 6175dcde96
14 changed files with 59 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Strata.SqlTools.Markdown.Tests/PostgreSql/QueryBreakdownGeneratorTests.cs
+14 -14
View File
@@ -21,7 +21,7 @@ public class QueryBreakdownGeneratorTests
var query = new QueryBreakdown("user_id, user_name", "users");
// Act
var result = _generator.GenerateMermaidDiagram(query, "Simple User Query");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Simple User Query");
// Assert
Assert.That(result, Does.Contain("```mermaid"));
@@ -44,7 +44,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("WHERE"));
@@ -64,7 +64,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("WHERE"));
@@ -89,7 +89,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query, "Users with Orders");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Users with Orders");
// Assert
Assert.That(result, Does.Contain("### Users with Orders"));
@@ -110,7 +110,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query, "Recent Users");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Recent Users");
// Assert
Assert.That(result, Does.Contain("SELECT"));
@@ -131,7 +131,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("SELECT"));
@@ -150,7 +150,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("SELECT"));
@@ -185,7 +185,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query, "Regional Sales Analysis");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Regional Sales Analysis");
// Assert
Assert.That(result, Does.Contain("### Regional Sales Analysis"));
@@ -209,7 +209,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("GROUP BY"));
@@ -223,7 +223,7 @@ public class QueryBreakdownGeneratorTests
var query = new QueryBreakdown("id", "orders");
// Act
var result = _generator.GenerateMermaidDiagram(query, null);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, null);
// Assert
Assert.That(result, Does.Not.Contain("###"));
@@ -238,7 +238,7 @@ public class QueryBreakdownGeneratorTests
var query = new QueryBreakdown("order_id", "orders");
// Act
var result = _generator.GenerateMermaidDiagram(query, "");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "");
// Assert
Assert.That(result, Does.Not.Contain("###"));
@@ -258,7 +258,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query, "Type Cast Example");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Type Cast Example");
// Assert
Assert.That(result, Does.Contain("SELECT"));
@@ -279,7 +279,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query, "JSON Data");
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "JSON Data");
// Assert
Assert.That(result, Does.Contain("SELECT"));
@@ -298,7 +298,7 @@ public class QueryBreakdownGeneratorTests
");
// Act
var result = _generator.GenerateMermaidDiagram(query);
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("SELECT"));
tests/Strata.SqlTools.Markdown.Tests/PostgreSql/SqlStatementGeneratorTests.cs
+9 -9
View File
@@ -25,7 +25,7 @@ public class SqlStatementGeneratorTests
");
// Act
var result = _generator.GenerateSequenceDiagram(query, "User Query Flow");
var result = SqlStatementGenerator.GenerateSequenceDiagram(query, "User Query Flow");
// Assert
Assert.That(result, Does.Contain("```mermaid"));
@@ -51,7 +51,7 @@ public class SqlStatementGeneratorTests
");
// Act
var result = _generator.GenerateSequenceDiagram(query);
var result = SqlStatementGenerator.GenerateSequenceDiagram(query);
// Assert
Assert.That(result, Does.Contain("Execute Main Statement"));
@@ -73,7 +73,7 @@ public class SqlStatementGeneratorTests
");
// Act
var result = _generator.GenerateSequenceDiagram(query, "Sales Analysis");
var result = SqlStatementGenerator.GenerateSequenceDiagram(query, "Sales Analysis");
// Assert
Assert.That(result, Does.Contain("### Sales Analysis"));
@@ -90,7 +90,7 @@ public class SqlStatementGeneratorTests
var tables = new[] { "customers", "orders", "order_items", "products" };
// Act
var result = _generator.GenerateEntityRelationshipDiagram(tables, "E-Commerce Schema");
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables, "E-Commerce Schema");
// Assert
Assert.That(result, Does.Contain("```mermaid"));
@@ -109,7 +109,7 @@ public class SqlStatementGeneratorTests
var tables = new[] { "\"Customers\"", "\"Orders\"", "\"OrderItems\"" };
// Act
var result = _generator.GenerateEntityRelationshipDiagram(tables);
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables);
// Assert
Assert.That(result, Does.Contain("erDiagram"));
@@ -123,7 +123,7 @@ public class SqlStatementGeneratorTests
var tables = new[] { "public.users", "sales.orders", "inventory.products" };
// Act
var result = _generator.GenerateEntityRelationshipDiagram(tables);
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables);
// Assert
Assert.That(result, Does.Contain("erDiagram"));
@@ -137,7 +137,7 @@ public class SqlStatementGeneratorTests
var tables = new[] { "users" };
// Act
var result = _generator.GenerateEntityRelationshipDiagram(tables);
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables);
// Assert
Assert.That(result, Does.Contain("erDiagram"));
@@ -151,7 +151,7 @@ public class SqlStatementGeneratorTests
var query = new QueryBreakdown("order_id", "orders");
// Act
var result = _generator.GenerateSequenceDiagram(query, null);
var result = SqlStatementGenerator.GenerateSequenceDiagram(query, null);
// Assert
Assert.That(result, Does.Not.Contain("###"));
@@ -170,7 +170,7 @@ public class SqlStatementGeneratorTests
");
// Act
var result = _generator.GenerateSequenceDiagram(query);
var result = SqlStatementGenerator.GenerateSequenceDiagram(query);
// Assert
Assert.That(result, Does.Contain("sequenceDiagram"));