Lambda-Associates/sql-utilities
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(sonar): adopt Has.Count, Is.Empty, Does.Contain, char overloads in tests (NUnit2046, NUnit2011, CA1866)

Browse Source 
- NUnit2046: `Assert.That(x.Count, Is.EqualTo(n))` → `Assert.That(x, Has.Count.EqualTo(n))` (or `Is.Empty` when n==0)
- NUnit2011: `Assert.That(s.Contains(x))` → `Assert.That(s, Does.Contain(x))` for richer failure messages
- CA1866: `.StartsWith("$"|"@"|":")` → `.StartsWith('$'|'@'|':')` char overload

Driven by `dotnet format analyzers --diagnostics NUnit2046 NUnit2011 CA1866`
for the cases the Roslyn fixer handles, plus a regex sweep for the remaining
`Count == n` (n>0) cases which the fixer doesn't address. CA1866 had no
associated code fix and was edited by hand (3 sites in 2 files). All tests
green (1180 passing).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thom Lamb
2026-05-27 11:58:00 -05:00
co-authored by Claude Opus 4.7
parent 5aca8e93fd
commit 505ada5017
24 changed files with 105 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Strata.SqlTools.SqlServer.Tests/SqlServer/QueryBreakdownTests.cs
+12 -12
View File
@@ -26,7 +26,7 @@ public class QueryBreakdownTests
Assert.That(query.SetupClauses, Is.Not.Null);
Assert.That(query.FinishClauses, Is.Not.Null);
Assert.That(query.WithClauses, Is.Not.Null);
Assert.That(query.WithClauses.Count, Is.EqualTo(0));
Assert.That(query.WithClauses, Is.Empty);
Assert.That(query.Parameters, Is.Not.Null);
Assert.That(query.ParameterList, Is.Not.Null);
}
@@ -208,7 +208,7 @@ public class QueryBreakdownTests
var merged = query.GetMergedParameters();
// Assert
Assert.That(merged.Count, Is.EqualTo(2));
Assert.That(merged, Has.Count.EqualTo(2));
Assert.That(merged["@UserId"], Is.EqualTo(123));
Assert.That(merged["@ActiveStatus"], Is.EqualTo(true));
}
@@ -228,7 +228,7 @@ public class QueryBreakdownTests
var merged = mainQuery.GetMergedParameters();
// Assert
Assert.That(merged.Count, Is.EqualTo(2));
Assert.That(merged, Has.Count.EqualTo(2));
Assert.That(merged["@MinDate"], Is.EqualTo(DateTime.Today.AddDays(-30)));
Assert.That(merged["@Limit"], Is.EqualTo(100));
}
@@ -252,7 +252,7 @@ public class QueryBreakdownTests
var merged = mainQuery.GetMergedParameters();
// Assert
Assert.That(merged.Count, Is.EqualTo(3));
Assert.That(merged, Has.Count.EqualTo(3));
Assert.That(merged["@Status1"], Is.EqualTo("active"));
Assert.That(merged["@MinDate"], Is.EqualTo(DateTime.Today.AddDays(-30)));
Assert.That(merged["@ResultLimit"], Is.EqualTo(50));
@@ -273,7 +273,7 @@ public class QueryBreakdownTests
var merged = mainQuery.GetMergedParameters();
// Assert
Assert.That(merged.Count, Is.EqualTo(1));
Assert.That(merged, Has.Count.EqualTo(1));
Assert.That(merged["@Limit"], Is.EqualTo(100)); // Main query value wins
}
@@ -296,7 +296,7 @@ public class QueryBreakdownTests
var merged = mainQuery.GetMergedParameters();
// Assert - All parameters from all levels should be present
Assert.That(merged.Count, Is.EqualTo(3));
Assert.That(merged, Has.Count.EqualTo(3));
Assert.That(merged["@InnerParam"], Is.EqualTo("inner_value"));
Assert.That(merged["@MiddleParam"], Is.EqualTo("middle_value"));
Assert.That(merged["@MainParam"], Is.EqualTo("main_value"));
@@ -317,7 +317,7 @@ public class QueryBreakdownTests
var merged = mainQuery.GetMergedParameters();
// Assert
Assert.That(merged.Count, Is.EqualTo(0));
Assert.That(merged, Is.Empty);
}
[Test]
@@ -464,7 +464,7 @@ public class QueryBreakdownTests
query.AddWhereClause("CreatedDate > @StartDate", "and");
// Assert
Assert.That(query.Parameters.Count, Is.EqualTo(3));
Assert.That(query.Parameters, Has.Count.EqualTo(3));
Assert.That(query.Parameters, Does.ContainKey("@UserId"));
Assert.That(query.Parameters, Does.ContainKey("@Status"));
Assert.That(query.Parameters, Does.ContainKey("@StartDate"));
@@ -566,7 +566,7 @@ public class QueryBreakdownTests
mainQuery.AddWithClause("ProductOrders", cteQuery);
// Assert
Assert.That(mainQuery.WithClauses.Count, Is.EqualTo(1));
Assert.That(mainQuery.WithClauses, Has.Count.EqualTo(1));
Assert.That(mainQuery.WithClauses[0].TableName, Is.EqualTo("ProductOrders"));
Assert.That(mainQuery.WithClauses[0].Query, Is.EqualTo(cteQuery));
}
@@ -586,7 +586,7 @@ public class QueryBreakdownTests
mainQuery.AddWithClause("CTE3", cte3);
// Assert
Assert.That(mainQuery.WithClauses.Count, Is.EqualTo(3));
Assert.That(mainQuery.WithClauses, Has.Count.EqualTo(3));
Assert.That(mainQuery.WithClauses[0].TableName, Is.EqualTo("CTE1"));
Assert.That(mainQuery.WithClauses[1].TableName, Is.EqualTo("CTE2"));
Assert.That(mainQuery.WithClauses[2].TableName, Is.EqualTo("CTE3"));
@@ -603,7 +603,7 @@ public class QueryBreakdownTests
mainQuery.AddWithClause("ProductOrders", cteSql, isMicrosoftSql: true);
// Assert
Assert.That(mainQuery.WithClauses.Count, Is.EqualTo(1));
Assert.That(mainQuery.WithClauses, Has.Count.EqualTo(1));
Assert.That(mainQuery.WithClauses[0].TableName, Is.EqualTo("ProductOrders"));
Assert.That(mainQuery.WithClauses[0].Query!.SelectClause.Clause, Does.Contain("ProductID"));
Assert.That(mainQuery.WithClauses[0].Query!.GroupByClause.Clause, Does.Contain("ProductID"));
@@ -769,7 +769,7 @@ public class QueryBreakdownTests
// Assert - Now using WITH clause
Assert.That(query.IsUsingWithClause, Is.True);
Assert.That(query.WithClauses.Count, Is.EqualTo(1));
Assert.That(query.WithClauses, Has.Count.EqualTo(1));
}
#endregion