From 3c602a4625f91fc029818ac7f01b4a0e5f598304 Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Wed, 27 May 2026 14:19:26 -0500 Subject: [PATCH] chore(sonar): mark private helpers static (CA1822) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two private methods that don't touch instance state get the `static` keyword: - `LinqExpressionVisitor.ExtractMemberName` - `Markdown.Expressions.ExpressionGenerator.GenerateMermaidDiagram(Expression)` Both have only intra-class callers, so this is a non-breaking change — the call sites continue to work unchanged under C# method-resolution. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs | 2 +- src/Strata.SqlTools.Markdown/Expressions/ExpressionGenerator.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs index c4b3e20..ab548fb 100644 --- a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs +++ b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs @@ -303,7 +303,7 @@ public class LinqExpressionVisitor : ExpressionVisitor return string.IsNullOrEmpty(name) ? "*" : name; } - private string ExtractMemberName(Expression expression) + private static string ExtractMemberName(Expression expression) { if (expression is MemberExpression member) { diff --git a/src/Strata.SqlTools.Markdown/Expressions/ExpressionGenerator.cs b/src/Strata.SqlTools.Markdown/Expressions/ExpressionGenerator.cs index 706d197..8f19153 100644 --- a/src/Strata.SqlTools.Markdown/Expressions/ExpressionGenerator.cs +++ b/src/Strata.SqlTools.Markdown/Expressions/ExpressionGenerator.cs @@ -245,7 +245,7 @@ public class ExpressionGenerator : IVisitor /// /// Generates a Mermaid tree diagram from an Expression tree. /// - private string GenerateMermaidDiagram(Expression expression) + private static string GenerateMermaidDiagram(Expression expression) { var sb = new StringBuilder(); sb.AppendLine("```mermaid");