Lambda-Associates/sql-utilities
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolving more duplicate lines issue
SonarQube Analysis / sonarqube (pull_request) Successful in 3m55s
Details

Browse Source
This commit is contained in:
Thom Lamb
2026-05-21 14:53:21 -05:00
parent c8b989c11f
commit 2e483c9fa8
4 changed files with 253 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Strata.SqlTools.Snowflake/Breakdowns/QueryBreakdownCollection.cs
+17 -190
View File
@@ -13,89 +13,21 @@ namespace Strata.SqlTools.Breakdowns.Snowflake;
/// time travel, snowflake-specific parameters (:parameter and @parameter syntax),
/// and proper batch handling.
/// </remarks>
public class QueryBreakdownCollection : SqlBreakdownCollection
public class QueryBreakdownCollection : SqlServer.QueryBreakdownCollectionBase<QueryBreakdown>
{
private readonly List<QueryBreakdown> _queryBreakdowns;
/// <summary>
/// Initializes a new instance of the <see cref="QueryBreakdownCollection"/> class for Snowflake.
/// </summary>
public QueryBreakdownCollection() : base()
{
_queryBreakdowns = new List<QueryBreakdown>();
}
/// <summary>
/// Initializes a new instance of the <see cref="QueryBreakdownCollection"/> class with initial query breakdowns.
/// </summary>
/// <param name="queryBreakdowns">The initial collection of query breakdowns.</param>
public QueryBreakdownCollection(IEnumerable<QueryBreakdown> queryBreakdowns)
: base(queryBreakdowns?.Cast<ISqlBreakdown>() ?? Enumerable.Empty<ISqlBreakdown>())
public QueryBreakdownCollection(IEnumerable<QueryBreakdown> queryBreakdowns) : base(queryBreakdowns)
{
_queryBreakdowns = new List<QueryBreakdown>(queryBreakdowns ?? Enumerable.Empty<QueryBreakdown>());
}
/// <summary>
/// Gets the collection of QueryBreakdown objects.
/// </summary>
public IReadOnlyList<QueryBreakdown> QueryBreakdowns => _queryBreakdowns.AsReadOnly();
/// <summary>
/// Adds a QueryBreakdown to the collection.
/// </summary>
/// <param name="queryBreakdown">The query breakdown to add.</param>
/// <exception cref="ArgumentNullException">Thrown when queryBreakdown is null.</exception>
public void Add(QueryBreakdown queryBreakdown)
{
if (queryBreakdown == null)
{
throw new ArgumentNullException(nameof(queryBreakdown));
}
_queryBreakdowns.Add(queryBreakdown);
base.Add(queryBreakdown);
}
/// <summary>
/// Adds multiple QueryBreakdowns to the collection.
/// </summary>
/// <param name="queryBreakdowns">The query breakdowns to add.</param>
/// <exception cref="ArgumentNullException">Thrown when queryBreakdowns is null.</exception>
public void AddRange(IEnumerable<QueryBreakdown> queryBreakdowns)
{
if (queryBreakdowns == null)
{
throw new ArgumentNullException(nameof(queryBreakdowns));
}
foreach (var breakdown in queryBreakdowns)
{
Add(breakdown);
}
}
/// <summary>
/// Removes a QueryBreakdown from the collection.
/// </summary>
/// <param name="queryBreakdown">The query breakdown to remove.</param>
/// <returns>True if removed; otherwise, false.</returns>
public bool Remove(QueryBreakdown queryBreakdown)
{
var removed = _queryBreakdowns.Remove(queryBreakdown);
if (removed)
{
base.Remove(queryBreakdown);
}
return removed;
}
/// <summary>
/// Clears all query breakdowns from the collection.
/// </summary>
public new void Clear()
{
_queryBreakdowns.Clear();
base.Clear();
}
/// <summary>
@@ -122,11 +54,11 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
}
// Add all queries with semicolon separators
if (_queryBreakdowns.Count > 0)
if (QueryBreakdownList.Count > 0)
{
for (int i = 0; i < _queryBreakdowns.Count; i++)
for (int i = 0; i < QueryBreakdownList.Count; i++)
{
var query = _queryBreakdowns[i];
var query = QueryBreakdownList[i];
var sql = query.GetSql(includeSetupFinish);
// Ensure proper termination
@@ -139,7 +71,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
}
// Add spacing between statements
if (i < _queryBreakdowns.Count - 1)
if (i < QueryBreakdownList.Count - 1)
{
sb.AppendLine();
sb.AppendLine();
@@ -161,7 +93,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns that reference stages.</returns>
public IEnumerable<QueryBreakdown> WhereUseStageReference(string? stageName = null)
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql();
@@ -193,7 +125,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns that use JSON functions or colon notation.</returns>
public IEnumerable<QueryBreakdown> WhereUseSemiStructuredData()
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql().ToUpperInvariant();
@@ -223,7 +155,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
// Normalize parameter name (remove : or @)
var cleanName = parameterName.TrimStart(':', '@');
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql();
return sql.Contains($":{cleanName}", StringComparison.OrdinalIgnoreCase) ||
@@ -240,7 +172,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns using time travel syntax.</returns>
public IEnumerable<QueryBreakdown> WhereUseTimeTravelFeature()
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql().ToUpperInvariant();
@@ -256,7 +188,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns using Snowflake-specific functions.</returns>
public IEnumerable<QueryBreakdown> WhereUseSnowflakeFunctions()
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql().ToUpperInvariant();
@@ -279,7 +211,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns using temporary tables.</returns>
public IEnumerable<QueryBreakdown> WhereUseTemporaryTables()
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql().ToUpperInvariant();
@@ -296,7 +228,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Query breakdowns using external data sources.</returns>
public IEnumerable<QueryBreakdown> WhereUseExternalData()
{
return _queryBreakdowns.Where(q =>
return QueryBreakdownList.Where(q =>
{
var sql = q.GetSql().ToUpperInvariant();
@@ -306,85 +238,13 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
});
}
/// <summary>
/// Filters queries by the SELECT clause content using Snowflake's format.
/// </summary>
/// <param name="selectContains">The text to find in the SELECT clause.</param>
/// <returns>Filtered query breakdowns.</returns>
public IEnumerable<QueryBreakdown> WhereSelectContains(string selectContains)
{
if (string.IsNullOrWhiteSpace(selectContains))
{
throw new ArgumentNullException(nameof(selectContains));
}
return _queryBreakdowns.Where(q =>
q.SelectClause?.Clause?.Contains(selectContains, StringComparison.OrdinalIgnoreCase) ?? false);
}
/// <summary>
/// Filters queries that reference specific tables or schemas.
/// </summary>
/// <param name="tableNameContains">The table name or schema pattern to find.</param>
/// <returns>Filtered query breakdowns.</returns>
public IEnumerable<QueryBreakdown> WhereTableContains(string tableNameContains)
{
if (string.IsNullOrWhiteSpace(tableNameContains))
{
throw new ArgumentNullException(nameof(tableNameContains));
}
return _queryBreakdowns.Where(q =>
q.FromClause?.Clause?.Contains(tableNameContains, StringComparison.OrdinalIgnoreCase) ?? false);
}
/// <summary>
/// Filters queries that have WHERE clauses.
/// </summary>
/// <returns>Query breakdowns with WHERE clauses.</returns>
public IEnumerable<QueryBreakdown> WhereHaveWhereClause()
{
return _queryBreakdowns.Where(q =>
!string.IsNullOrWhiteSpace(q.WhereClause?.Clause));
}
/// <summary>
/// Filters queries without WHERE clauses (potentially risky for full table scans).
/// </summary>
/// <returns>Query breakdowns without WHERE clauses.</returns>
public IEnumerable<QueryBreakdown> WhereHaveNoWhereClause()
{
return _queryBreakdowns.Where(q =>
string.IsNullOrWhiteSpace(q.WhereClause?.Clause));
}
/// <summary>
/// Filters queries that have GROUP BY clauses.
/// </summary>
/// <returns>Query breakdowns with GROUP BY clauses.</returns>
public IEnumerable<QueryBreakdown> WhereHaveGroupByClause()
{
return _queryBreakdowns.Where(q =>
!string.IsNullOrWhiteSpace(q.GroupByClause?.Clause));
}
/// <summary>
/// Filters queries that have ORDER BY clauses.
/// </summary>
/// <returns>Query breakdowns with ORDER BY clauses.</returns>
public IEnumerable<QueryBreakdown> WhereHaveOrderByClause()
{
return _queryBreakdowns.Where(q =>
!string.IsNullOrWhiteSpace(q.OrderByClause?.Clause));
}
/// <summary>
/// Gets a comprehensive analysis of all queries in the collection.
/// </summary>
/// <returns>Analysis summary for each query.</returns>
public IEnumerable<SnowflakeQueryAnalysis> AnalyzeQueries()
{
return _queryBreakdowns.Select((q, index) => new SnowflakeQueryAnalysis
return QueryBreakdownList.Select((q, index) => new SnowflakeQueryAnalysis
{
Index = index,
HasSelectClause = !string.IsNullOrWhiteSpace(q.SelectClause?.Clause),
@@ -469,13 +329,6 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
sql.Contains("COPY INTO @");
}
/// <summary>
/// Synchronizes parameter values across all queries in the collection.
/// Ensures that if a parameter with the same name exists in multiple queries, they all have the same value.
/// </summary>
public void SynchronizeParameters()
=> SqlServer.QueryCollectionAnalysisHelper.SynchronizeParameters(_queryBreakdowns);
/// <summary>
/// Adds a parameter with a specific value to all queries in the collection.
/// </summary>
@@ -488,19 +341,12 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
throw new ArgumentException("Parameter name cannot be null or empty.", nameof(parameterName));
}
foreach (var query in _queryBreakdowns)
foreach (var query in QueryBreakdownList)
{
query.Parameters[parameterName] = value!;
}
}
/// <summary>
/// Gets all unique parameters from all queries in the collection as a combined dictionary.
/// </summary>
/// <returns>A dictionary containing all unique parameters across all queries.</returns>
protected Dictionary<string, object?> GetCombinedParameterDictionary()
=> SqlServer.QueryCollectionAnalysisHelper.GetCombinedParameters(_queryBreakdowns);
/// <summary>
/// Gets a formatted string representation of all unique parameters with Snowflake-specific syntax.
/// </summary>
@@ -551,7 +397,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
/// <returns>Parameter usage information.</returns>
public IEnumerable<ParameterUsageReport> GetParameterUsageReport()
{
return SqlServer.QueryCollectionAnalysisHelper.GetParameterUsage(_queryBreakdowns)
return SqlServer.QueryCollectionAnalysisHelper.GetParameterUsage(QueryBreakdownList)
.Select(usage => new ParameterUsageReport
{
ParameterName = usage.Name,
@@ -561,25 +407,6 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
});
}
/// <summary>
/// Gets the total number of columns selected across all queries.
/// </summary>
/// <returns>Total column count.</returns>
public int GetTotalSelectedColumns()
=> SqlServer.QueryCollectionAnalysisHelper.GetTotalSelectedColumns(_queryBreakdowns);
/// <summary>
/// Gets all unique table names referenced across all queries.
/// </summary>
/// <remarks>
/// This provides a quick overview of which tables are being queried.
/// Note: This is a best-effort extraction and may not capture all table references,
/// especially in complex subqueries or with aliasing.
/// </remarks>
/// <returns>List of unique table names.</returns>
public IEnumerable<string> GetUniqueTableReferences()
=> SqlServer.QueryCollectionAnalysisHelper.GetUniqueTableReferences(_queryBreakdowns);
/// <summary>
/// Gets a summary of all queries including their types and basic composition.
/// </summary>
@@ -589,7 +416,7 @@ public class QueryBreakdownCollection : SqlBreakdownCollection
var stageQueries = WhereUseStageReference().ToHashSet();
var semiStructuredQueries = WhereUseSemiStructuredData().ToHashSet();
return _queryBreakdowns.Select((q, index) => new SnowflakeQueryAnalysis
return QueryBreakdownList.Select((q, index) => new SnowflakeQueryAnalysis
{
Index = index,
HasSelectClause = !string.IsNullOrWhiteSpace(q.SelectClause?.Clause),