From 1124e91141cd9ea2fca7a9ccd5741554d72984c5 Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Tue, 26 May 2026 09:25:34 -0500 Subject: [PATCH] chore(sonar): remove three unused local variables (S1481) - LinqQueryBreakdown.cs:211 - drop unused `expr` pattern binding (type test remains) - LinqQueryBreakdown.cs:279 - drop unused `firstEntity` (empty check already above) - LinqExpressionVisitor.cs:315 - drop unused `param` pattern binding Co-Authored-By: Claude Opus 4.7 (1M context) --- .claude/skills/sonarqube/SKILL.MD | 0 .../Breakdowns/LinqQueryBreakdown.cs | 5 ++--- .../Visitors/LinqExpressionVisitor.cs | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 .claude/skills/sonarqube/SKILL.MD diff --git a/.claude/skills/sonarqube/SKILL.MD b/.claude/skills/sonarqube/SKILL.MD new file mode 100644 index 0000000..e69de29 diff --git a/src/Strata.SqlTools.LinqToSql/Breakdowns/LinqQueryBreakdown.cs b/src/Strata.SqlTools.LinqToSql/Breakdowns/LinqQueryBreakdown.cs index d7074cd..eac22d4 100644 --- a/src/Strata.SqlTools.LinqToSql/Breakdowns/LinqQueryBreakdown.cs +++ b/src/Strata.SqlTools.LinqToSql/Breakdowns/LinqQueryBreakdown.cs @@ -208,7 +208,7 @@ public class LinqQueryBreakdown : QueryBreakdown { // If the original expression can be converted to IQueryable, use it // Otherwise, we cannot safely reconstruct without the original query provider - if (OriginalExpression is Expression expr && EntityType == typeof(T)) + if (OriginalExpression is Expression && EntityType == typeof(T)) { // We have the expression, but we don't have the provider to create IQueryable // The breakdown analysis is one-way; reconstruction requires the original provider @@ -275,8 +275,7 @@ public class LinqQueryBreakdown : QueryBreakdown var breakdown = new Breakdowns.SqlServer.InsertBreakdown(); breakdown.TableName.Clause = typeof(T).Name; - // Use first entity to get column names - var firstEntity = entitiesList.First(); + // Use the entity type to get column names var properties = typeof(T).GetProperties(); var columnNames = new List(); diff --git a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs index fc1e324..9e52b0d 100644 --- a/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs +++ b/src/Strata.SqlTools.LinqToSql/Visitors/LinqExpressionVisitor.cs @@ -312,7 +312,7 @@ public class LinqExpressionVisitor : ExpressionVisitor return GetFullMemberName(member); } - if (expression is ParameterExpression param) + if (expression is ParameterExpression) { return "*"; }