From 06e826a13c9c2221d46c1452c8d83173af0039ff Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Tue, 26 May 2026 09:27:15 -0500 Subject: [PATCH] chore(sonar): drop redundant inline init now set in ctor (S3604) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SqlServer/Breakdowns/QueryBreakdown.cs:26 — _clausesCacheDirty was both initialized inline (= true) and re-assigned in the constructor at line 56. Drop the inline initializer; the ctor remains authoritative. The four nearby S3604 false-positives on clause backing fields stay suppressed via #pragma — they are write-through targets of cache-invalidating property setters. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/Strata.SqlTools.SqlServer/Breakdowns/QueryBreakdown.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Strata.SqlTools.SqlServer/Breakdowns/QueryBreakdown.cs b/src/Strata.SqlTools.SqlServer/Breakdowns/QueryBreakdown.cs index 494c6e5..b816559 100644 --- a/src/Strata.SqlTools.SqlServer/Breakdowns/QueryBreakdown.cs +++ b/src/Strata.SqlTools.SqlServer/Breakdowns/QueryBreakdown.cs @@ -23,7 +23,7 @@ public class QueryBreakdown : SqlBreakdownBase, IQueryBreakdown // Caching fields for GetClauses() performance optimization private SqlClauses? _cachedClauses; - private bool _clausesCacheDirty = true; + private bool _clausesCacheDirty; // Backing fields for clause properties to support cache invalidation #pragma warning disable S3604 // "Fields should not be write-only" - False positive: These fields are used as backing fields for properties that manage cache invalidation