chore: refactor for sonarqube issues

2026-05-22 17:13:31 -05:00
parent 063d5a7ba0
commit 012e693fe1
22 changed files with 522 additions and 461 deletions
@@ -13,7 +13,6 @@ public class Value

    public Value() : this(string.Empty, string.Empty, new int[0], new string[0], new CalculationFilterGroup[0])
    {
-        // FilterGroups = new List<CalculationFilterGroup>();
    }

    [JsonConstructor]
@@ -22,7 +21,7 @@ public class Value
        ColumnAlias = columnAlias;
        Calculation = calculation;
        CalculationDataColumnIds = calculationDataColumnIds ?? Array.Empty<int>();
-        AliasedIds = aliasedIds ?? aliasedIds ?? Array.Empty<string>();
+        AliasedIds = aliasedIds ?? Array.Empty<string>();
        FilterGroups = filterGroups?.Where(x => x.IsValid()).ToList() ?? new List<CalculationFilterGroup>();
    }
 }